Skip to content
This repository was archived by the owner on Oct 24, 2025. It is now read-only.

Update slim.js#220

Merged
dschep merged 2 commits intoserverless:masterfrom
benjipott:patch-2
Jul 18, 2018
Merged

Update slim.js#220
dschep merged 2 commits intoserverless:masterfrom
benjipott:patch-2

Conversation

@benjipott
Copy link
Copy Markdown
Contributor

Update slim option to match regex folder like "*tensorflo/core"

Update slim option to match regex folder like tensorflow\/core
@dschep
Copy link
Copy Markdown
Contributor

dschep commented Jul 18, 2018

Why wouldn't that pattern work with -name? In fact, it seems the change includes a leading . which is an implicit behavior I'd rather avoid. Longer term.. I wanna replace all this find based code with pure js glob-all based code so that slim (other than the use of strip) is fully crossplatform.

@benjipott
Copy link
Copy Markdown
Contributor Author

if i use -name and want to exclude tensorflow/test but not peewee/test my exclude pattern should be *test* but exclude all test folder.

@benjipott
Copy link
Copy Markdown
Contributor Author

benjipott commented Jul 18, 2018

-wholename instead of -name do the job

Copy link
Copy Markdown
Contributor

@dschep dschep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This soln I like!

@dschep dschep merged commit 45e180b into serverless:master Jul 18, 2018
@dschep
Copy link
Copy Markdown
Contributor

dschep commented Jul 18, 2018

released in 4.1.1

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants